Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

improvement: add detailed information when operation has exception #106

Merged
merged 12 commits into from
May 19, 2020
Merged

improvement: add detailed information when operation has exception #106

merged 12 commits into from
May 19, 2020

Conversation

foreverneverer
Copy link
Contributor

For finding necessary information more quickly, This pr add some detail message when user's operation happens exception.

  • add meta server ip
  • add key string and multi request count

as follow:

Caused by: com.xiaomi.infra.pegasus.rpc.ReplicationException: ERR_TIMEOUT: [metaServer=[127.0.0.1:34601, 127.0.0.1:34602, 127.0.0.1:34603], table=temp, request=[hashKey=dns_hash_key,sortKey=dns_sort_key,valueCount=1], timeout=5ms]

or

com.xiaomi.infra.pegasus.rpc.ReplicationException: ERR_TIMEOUT: [metaServer=[127.0.0.1:34601, 127.0.0.1:34602, 127.0.0.1:34603],table=temp,operation=put,request=[hashKey=hashKey,sortKey=sortKey,valueCount=1],replicaServer=10.232.52.164:34801,gpid=(gpid(3.1)),timeout=1000ms] The operation is timed out!

@neverchanje neverchanje changed the title feat: add detail information when user's operation happens exception improvement: add detailed information when operation has exception May 18, 2020
@neverchanje neverchanje merged commit 67d48d6 into XiaoMi:thrift-0.11.0-inlined May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@levy5307 levy5307 levy5307 left review comments

@neverchanje neverchanje neverchanje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foreverneverer @neverchanje @levy5307